Adding odf module and example #3

kosilva93 · 2022-01-14T18:55:15Z

No description provided.

…aned up the code and updated metadata.yaml

kosilva93 · 2022-02-19T10:20:22Z

@umarali-nagoor

akgunjal

check comments

examples/odf/README.md

akgunjal · 2022-02-28T10:58:40Z

examples/odf/README.md

+
+After the service shows as active in the IBM Cloud resource view, verify the deployment:
+
+    ibmcloud oc cluster addon ls -c <cluster_name>


Remove oc from here as its not needed in ibmcloud command

We need oc to run the addon enable command in our shell script

@kosilva93 This command can be converted to ibmcloud ks cluster addon ls -c <cluster_name>. You need to add to the README that the ibmcloud container-service/kubernetes-service plugin is required. This can be added with the command ibmcloud plugin install kubernetes-service.

akgunjal · 2022-02-28T11:00:09Z

examples/portworx/variables.tf

@@ -7,23 +7,23 @@ variable "install_storage" {
  description = "If set to false does not install storage and attach the volumes to the worker nodes. Enabled by default"
 }

-variable unique_id {
+variable "unique_id" {


Do this file need to be removed as its for portworx?

This one is correct as it is in the examples/portworx/variables.tf file. It should be removed from the examples/odf/variables.tf file

akgunjal · 2022-02-28T11:00:41Z

metadata.yaml

@@ -11,7 +11,7 @@ owner: "ibmtfprovider"
 published_at: "2021-12-02T10:34:28.911362Z"
 registry: "https://registry.terraform.io/modules/terraform-ibm-modules/cluster-storage/ibm/latest"
 alias: "portworx"
-tags: ["portworx","storage","cluster","cluster-storage"]
+tags: ["portworx","storage","cluster","cluster-storage","odf"]


portworx needs to removed here?

Since portworx and odf are combined in the same module directory, shouldn't they be combined in the same metadata.yaml file?

akgunjal · 2022-02-28T11:01:06Z

metadata.yaml

+        is_nullable: false
+        is_force_new: false
+        is_provision_controller: false
+        is_count_controller: false
    outputs:
      - name: "portworx_is_ready"


portworx needs to removed here?

Portworx and odf are combined in this same directory.

scripts/install_odf.sh

annumberhocker · 2022-03-04T15:41:19Z

examples/odf/README.md

+Create the file `test.auto.tfvars` with the following input variables, these values are fake examples:
+
+```hcl
+enable                  = true


@kosilva93 These options are not accurate. Need to update

annumberhocker · 2022-03-04T15:42:11Z

examples/odf/main.tf

+
+module "odf" {
+  source = "./../.."
+  // TODO: With Terraform 0.13 replace the parameter 'enable' or the conditional expression using 'with_iaf' with 'count'


Remove this comment

annumberhocker · 2022-03-04T15:42:34Z

examples/odf/variables.tf

+  description = "The cluster where we are going to enable ODF"
+}
+
+variable "region" {


This variable description needs to be updated to say

"The region of the cluster ODF will be installed on: us-south, us-east, eu-gb, eu-de, jp-tok, au-syd, etc."

annumberhocker · 2022-03-04T20:26:26Z

examples/odf/README.md

+
+## 4. Cleanup
+
+WIP


add Running terraform destroy will disable the ODF extension.

…ast revision

kosilva93 · 2022-03-16T20:58:29Z

new push made for review

umarali-nagoor · 2022-03-02T07:40:11Z

examples/odf/README.md

@@ -0,0 +1,74 @@
+# Test ODF Terraform Module
+


ODF examples directory should have following files

Versions.tf

output.tf

@kosilva93 output.tf still missing from examples/odf

umarali-nagoor · 2022-03-02T07:41:58Z

examples/odf/variables.tf

+  description = "If set to true installs ODF on the given cluster"
+}
+
+variable "ibmcloud_api_key" {


Where are we passing/using this variable ?

The scripts/install_odf.sh requires it to run some ibmcloud cli commands.

umarali-nagoor · 2022-03-02T07:46:59Z

variables.tf

  description = "Name of the namespace"
  type        = string
  default     = "kube-system"
 }

-variable pwx_plan {


Please don't make any changes to files not related to ODF. Revert back the changes.

The only changes were to wrap the variable names with "". I think the vscode .tf extension probably did this as it is best practice

annumberhocker · 2022-04-01T21:37:12Z

scripts/install_odf.sh

+
+
+# Retrieve the openshift cluster version
+ROKS_VERSION=`oc get clusterversion -o jsonpath='{.items[].status.history[].version}{"\n"}'`


Use kubectl instead of oc. We can not require a user to download the oc command since they might not have an OpenShift account to download it from.

annumberhocker · 2022-04-01T21:37:37Z

scripts/install_odf.sh

+
+if [ $ROKS_VERSION_COMP -ge 470 ]; then
+    echo "Supported version";
+    ibmcloud oc cluster addon enable openshift-data-foundation -c ${CLUSTER} --version ${ROKS_VERSION} \


I think this can be changed to ibmcloud ks cluster addon enable openshift-data-foundation

annumberhocker · 2022-04-01T21:38:07Z

scripts/uninstall_odf.sh

+ibmcloud login -apikey ${IC_API_KEY}
+ibmcloud ks cluster config -c ${CLUSTER} --admin
+
+ibmcloud oc cluster addon disable openshift-data-foundation -c ${CLUSTER} -f


change to ibmcloud ks cluster addon...

annumberhocker

@kosilva93 these things still need to be fixed:

examples/odf directory should have an output.tf file that basically passes thru the odf_is_ready variable.
Fix kube_config_path variable in examples/odf/variables.tf and variables.tf to be:

variable "kube_config_path" {
   description = "Directory to store the kubeconfig file. If running on Schematics, use `/tmp/.schematics/.kube/config`"
   type        = string
   default     = "./.kube/config"
}

Why is the unique_id Portworx variable needed in examples/odf/variables.tf and examples/odf/main.tf? ODF shouldn't really need to know about this. If you remove it from variables.tf and main.tf it shouldn't create an error since the odf.tf file doesn't require it as input.
Fix description of region in examples/odf/variables.tf to:

 The region of the cluster ODF will be installed on: us-south, us-east, eu-gb, eu-de, jp-tok, au-syd, etc.

There are still a couple of uses of oc in the scripts/install_odf.sh file. Replace with kubectl

Kevin Silva added 4 commits January 14, 2022 17:54

Adding odf module and example

c7fdac3

Forgot to update oc to kubectl command

95de850

Made changes that were pointed out by Umar. Moved odf.tf to root, cle…

b505add

…aned up the code and updated metadata.yaml

Updated odf code

449593f

kosilva93 closed this Feb 19, 2022

kosilva93 reopened this Feb 19, 2022

kosilva93 closed this Feb 19, 2022

kosilva93 deleted the odf branch February 19, 2022 10:19

kosilva93 restored the odf branch February 19, 2022 10:19

kosilva93 reopened this Feb 19, 2022

akgunjal suggested changes Feb 28, 2022

View reviewed changes

umarali-nagoor self-requested a review March 2, 2022 07:54

annumberhocker reviewed Mar 4, 2022

View reviewed changes

Added new parameters value for ODF and fixed comments received from l…

d1ffd40

…ast revision

New push after running pre-commit

9518ddd

umarali-nagoor reviewed Mar 24, 2022

View reviewed changes

annumberhocker reviewed Apr 1, 2022

View reviewed changes

Kevin Silva added 6 commits April 18, 2022 15:33

ODF install template added

6149bb7

code update

5f8ca05

fix error for terraform.validate workflow - 1

c614497

fix error for terraform.validate workflow - 2

5b552cf

fix error for terraform.validate workflow - 3

4cd8a3b

fix error for terraform.validate workflow - 4

3d6fcba

Kevin Silva added 11 commits April 29, 2022 13:09

fix error for terraform.validate workflow - 14

4b2f2de

fix error for terraform.validate workflow - 15

83de4ea

fix error for terraform.validate workflow - 16

3c91df5

code update

ad8b1db

code update - fix 1

cc2e99a

code update - fix 2

254d8c9

code update - fix 4

b434c7c

code update - fix 5

1bdee57

code update - fix 6

246b303

code update - fix 7

aac28aa

code update - fix 8

2ede39b

annumberhocker suggested changes Jul 6, 2022

View reviewed changes

Kevin Silva added 18 commits July 25, 2022 17:56

clean odf module terraform-ibm-modules#1

18f3709

clean odf module #2

b684fcc

clean odf module #2

7efdf6e

clean odf module terraform-ibm-modules#3

b81334e

clean odf module #4

43f0e07

clean odf module #5

13ee230

clean odf module terraform-ibm-modules#6

5e098fd

clean odf module terraform-ibm-modules#7

1185995

clean odf module terraform-ibm-modules#8

ce9207b

clean odf module terraform-ibm-modules#9

1628e28

clean odf module terraform-ibm-modules#10

70e4537

clean odf module terraform-ibm-modules#11

e5c7cb8

clean odf module terraform-ibm-modules#12

e54596a

clean odf module #13

e303ab8

clean odf module #14

2f65c5d

clean odf module #15

a59e782

clean odf module #16

4bf0046

clean odf module #17

a9a3842

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding odf module and example #3

Adding odf module and example #3

kosilva93 commented Jan 14, 2022

kosilva93 commented Feb 19, 2022

akgunjal left a comment

akgunjal Feb 28, 2022

kosilva93 Mar 16, 2022

annumberhocker Apr 1, 2022 •

edited

Loading

akgunjal Feb 28, 2022

annumberhocker Jul 6, 2022

akgunjal Feb 28, 2022

annumberhocker Apr 1, 2022

akgunjal Feb 28, 2022

annumberhocker Apr 1, 2022

annumberhocker Mar 4, 2022 •

edited

Loading

annumberhocker Mar 4, 2022

annumberhocker Mar 4, 2022 •

edited

Loading

annumberhocker Mar 4, 2022

kosilva93 Mar 16, 2022

kosilva93 commented Mar 16, 2022

umarali-nagoor Mar 2, 2022

annumberhocker Jul 6, 2022

umarali-nagoor Mar 2, 2022

annumberhocker Apr 1, 2022 •

edited

Loading

umarali-nagoor Mar 2, 2022

annumberhocker Apr 1, 2022 •

edited

Loading

annumberhocker Apr 1, 2022

annumberhocker Apr 1, 2022

annumberhocker Apr 1, 2022

annumberhocker left a comment •

edited

Loading


		After the service shows as active in the IBM Cloud resource view, verify the deployment:

		ibmcloud oc cluster addon ls -c <cluster_name>



		# Retrieve the openshift cluster version
		ROKS_VERSION=`oc get clusterversion -o jsonpath='{.items[].status.history[].version}{"\n"}'`


		## 4. Cleanup

		WIP

Adding odf module and example #3

Are you sure you want to change the base?

Adding odf module and example #3

Conversation

kosilva93 commented Jan 14, 2022

kosilva93 commented Feb 19, 2022

akgunjal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annumberhocker Apr 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annumberhocker Mar 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annumberhocker Mar 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kosilva93 commented Mar 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annumberhocker Apr 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annumberhocker Apr 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annumberhocker left a comment • edited Loading

Choose a reason for hiding this comment

annumberhocker Apr 1, 2022 •

edited

Loading

annumberhocker Mar 4, 2022 •

edited

Loading

annumberhocker Mar 4, 2022 •

edited

Loading

annumberhocker Apr 1, 2022 •

edited

Loading

annumberhocker Apr 1, 2022 •

edited

Loading

annumberhocker left a comment •

edited

Loading