Add tests for the fix in PR #6538 #6652
Open
+88
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gow
commented
Oct 11, 2024
| assert.NotNil(t, dbHandle) | ||
|
|
||
| for i := 0; i < tc.numRetries; i++ { | ||
| <-time.NewTimer(tc.retryDelay).C |
There was a problem hiding this comment.
This is to make the linter not complain. Otherwise this is the same as time.Sleep(). Once we make sessionRefreshMinInternal a config value, we can override it in tests and not depend on timers then.
There was a problem hiding this comment.
How possible would it be to plumb a mock clock (or temporal's time source) into the dbhandle? That would let us test it without the raciness of a real sleep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
A critical bug was fixed in PR #6538. These are the associated tests to prevent regression.
Why?
Adding tests for a bug fix.
How did you test it?
Reverted the PR locally and ensured the tests catch it.
Potential risks
N/A