Disable more flaky tests #6648
Open
Disable more flaky tests #6648
+22
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
commented
Oct 11, 2024
| @@ -119,7 +119,7 @@ jobs: | |||
| - uses: actions/setup-go@v5 | |||
| if: ${{ !inputs.run_single_functional_test && !inputs.run_single_unit_test }} | |||
| with: | |||
| go-version-file: 'go.mod' | |||
| go-version-file: "go.mod" | |||
There was a problem hiding this comment.
VS code's fault. I can revert if this bugs anyone.
dnr
reviewed
Oct 11, 2024
| @@ -139,6 +139,8 @@ func TestReadLevelForAllExpiredTasksInBatch(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestTaskWriterShutdown(t *testing.T) { | |||
| t.Skip("flaky test") | |||
There was a problem hiding this comment.
this one is fixed here: #6627
please leave this out
Makefile
Outdated
| TEST_TIMEOUT ?= 30m | ||
| # 40 minutes is the upper bound defined for all tests, the longer running ones at the time of writing are XDC tests. The | ||
| # 40 minute timeout is also defined in run-tests.yml | ||
| TEST_TIMEOUT ?= 40m |
There was a problem hiding this comment.
there are two spots that need to be updated now, and the values need to be > this value. see 2ccbe18 (#6595)
There was a problem hiding this comment.
(btw 6595 makes xdc tests run in < 10 minutes. I'll reduce this after that goes in.)
bergundy
commented
Oct 11, 2024
| @@ -139,6 +139,8 @@ func TestReadLevelForAllExpiredTasksInBatch(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestTaskWriterShutdown(t *testing.T) { | |||
| t.Skip("flaky test") | |||
There was a problem hiding this comment.
I'll remove this, just saw it was fixed: 2fd735d
bergundy
commented
Oct 11, 2024
Follow up to temporalio#6634, the following tests are still flaky: ``` TestTaskWriterShutdown TestVersioningFunctionalSuite/TestDispatchRetry TestUpdateWorkflowSdkSuite/TestUpdateWorkflow_TimeoutWorkflowAfterUpdateAccepted ``` Also increased XDC timeout to 40 minutes since those tests occasionally time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6634, the following tests are still flaky:
Also increased XDC timeout to 40 minutes since those tests occasionally time out.