Workflow Update: abort updates with failure if update was accepted but workflow completes #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Oct 9, 2024
Comment on lines
-274
to
-279
| abortErr := reason.Error() | ||
| if reason == AbortReasonWorkflowContinuing { | ||
| // Accepted Update can't be applied to the new run, and must be aborted | ||
| // same way as if Workflow is completed. | ||
| abortErr = AbortReasonWorkflowCompleted.Error() | ||
| } |
There was a problem hiding this comment.
I am happy to remove this hack.
…t workflow completes
alexshtin
force-pushed
the
fix/fail-accepted-update-on-wf-complete
branch
from
33ab6a0
to
fddf0d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Abort updates with failure if update was accepted but workflow completes.
Why?
Accepted Updates are failed with special server failure because if a client knows that Update has been accepted, it expects any following requests to return an Update result (or failure) but not an error. There can be different types of Update failures coming from worker and a client must handle them anyway. It is easier and less error-prone for a client to handle only Update failures instead of both failures and not obvious
NotFounderrors in case if the Workflow completes before the Update completes.How did you test it?
Modified existing tests.
Potential risks
It is some sort of breaking change for very narrow case though.
Documentation
TBD
Is hotfix candidate?
No.