-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replication task equivalent back to source cluster #6549
base: main
Are you sure you want to change the base?
Conversation
syncStateErr *serviceerrors.SyncState, | ||
remainingAttempt int, | ||
) (bool, error) { | ||
return false, serviceerror.NewUnimplemented("not implemented") // TODO | ||
|
||
remoteAdminClient, err := e.ClientBean.GetRemoteAdminClient(e.sourceClusterName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main change is here.
}) | ||
if err != nil { | ||
var syncStateErr *serviceerrors.SyncState | ||
if !errors.As(err, &syncStateErr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Do we need a specific error to indicate that transition history is disabled in source cluster? Or we just add task equivalents back to source cluster in all error cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I am even debating if SyncState is the right error type to use here.
I will switch to FailedPrecondition type.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?