Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action inputs to dispatch n-runs of a single test in CI #6297
Action inputs to dispatch n-runs of a single test in CI #6297
Changes from 42 commits
f5301c6
377d713
c05a1a1
6fb13fd
82acc5c
56b97cf
320ed3d
94a6f2c
774403d
cd5160b
f055929
451f80c
ceeaca4
6ddda0b
fc7ead3
ce29c65
8fbe6df
bc76889
69a0a37
ee8e476
be78354
0a9d473
f6b52ea
5647d44
dd629bc
9a78b44
a129047
7292977
4980a86
189b6a9
241cf33
9c1f858
f4f8752
b29a900
2eacb72
8d05095
537294b
e9d8f11
c33c0a4
56e19ef
8278452
1ae8df0
2a95b20
3ef7261
945dc27
5470ba7
55962e8
f9f1533
09d7fe6
532c0a9
07ce206
3d226a4
7824291
3acb316
e525fd4
c74c23d
fe5c796
b4ff739
3e826a3
a082423
a31d78b
f6f6873
e2e0d15
2540f46
e9ce2a7
ed9233b
fdcaa7f
b7d9ccc
fc558d9
2db8d87
5951bb3
7417f3d
16ee81e
edb5343
90c4962
f16eb70
89b47d1
20e1f1e
b70af29
cb7d6c1
c857565
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to quote the boolean values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it with quoting the boolean value and it didn't work, whereas what is currently in the PR works. Not sure why, but I've tried both ways multiple times and I'm very sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm.. actually, I need to test this more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
github.events.inputs
is required though, per https://github.blog/changelog/2022-06-10-github-actions-inputs-unified-across-manual-and-reusable-workflows/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok yeah, it has to be
!= true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/temporalio/temporal/actions/runs/9961930639 this run is with the single_test input boolean checked, and
!= 'true'
, and the unit tests and integration tests run, which is not what I wantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/temporalio/temporal/actions/runs/9962244076 this run is with the single_test input boolean checked and
!= true
, and the unit tests and integration tests are correctly skippedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, did you try with single quote? Strings in GHA expressions must be in single quotes, not double quotes:
'true'
works"true"
does not workSee actions/runner#1483 and actions/runner#2238.