-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nexus operation link support #2266
Open
Quinn-With-Two-Ns
wants to merge
2
commits into
temporalio:nexus
Choose a base branch
from
Quinn-With-Two-Ns:issue-2245
base: nexus
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletions
139
temporal-sdk/src/test/java/io/temporal/workflow/nexus/WorkflowOperationLinkingTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| /* | ||
| * Copyright (C) 2022 Temporal Technologies, Inc. All Rights Reserved. | ||
| * | ||
| * Copyright (C) 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Modifications copyright (C) 2017 Uber Technologies, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this material except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.temporal.workflow.nexus; | ||
|
|
||
| import static io.temporal.internal.common.WorkflowExecutionUtils.getEventOfType; | ||
|
|
||
| import io.nexusrpc.handler.OperationHandler; | ||
| import io.nexusrpc.handler.OperationImpl; | ||
| import io.nexusrpc.handler.ServiceImpl; | ||
| import io.temporal.api.enums.v1.EventType; | ||
| import io.temporal.api.history.v1.History; | ||
| import io.temporal.api.history.v1.HistoryEvent; | ||
| import io.temporal.client.WorkflowOptions; | ||
| import io.temporal.client.WorkflowStub; | ||
| import io.temporal.nexus.WorkflowClientOperationHandlers; | ||
| import io.temporal.testing.internal.SDKTestWorkflowRule; | ||
| import io.temporal.workflow.*; | ||
| import io.temporal.workflow.shared.TestNexusServices; | ||
| import io.temporal.workflow.shared.TestWorkflows; | ||
| import java.time.Duration; | ||
| import org.junit.Assert; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
|
|
||
| public class WorkflowOperationLinkingTest extends BaseNexusTest { | ||
| @Rule | ||
| public SDKTestWorkflowRule testWorkflowRule = | ||
| SDKTestWorkflowRule.newBuilder() | ||
| .setWorkflowTypes(TestNexus.class, TestOperationWorkflow.class) | ||
| .setNexusServiceImplementation(new TestNexusServiceImpl()) | ||
| .build(); | ||
|
|
||
| @Override | ||
| protected SDKTestWorkflowRule getTestWorkflowRule() { | ||
| return testWorkflowRule; | ||
| } | ||
|
|
||
| @Test | ||
| public void testWorkflowOperationLinks() { | ||
| TestWorkflows.TestWorkflow1 workflowStub = | ||
| testWorkflowRule.newWorkflowStubTimeoutOptions(TestWorkflows.TestWorkflow1.class); | ||
| String result = workflowStub.execute(testWorkflowRule.getTaskQueue()); | ||
| Assert.assertEquals("Hello from operation workflow " + testWorkflowRule.getTaskQueue(), result); | ||
| History history = | ||
| testWorkflowRule | ||
| .getWorkflowClient() | ||
| .fetchHistory(WorkflowStub.fromTyped(workflowStub).getExecution().getWorkflowId()) | ||
| .getHistory(); | ||
| // Assert that the operation started event has a link to the workflow execution started event | ||
| HistoryEvent nexusStartedEvent = | ||
| getEventOfType(history, EventType.EVENT_TYPE_NEXUS_OPERATION_STARTED); | ||
| Assert.assertEquals(1, nexusStartedEvent.getLinksCount()); | ||
| Assert.assertEquals( | ||
| EventType.EVENT_TYPE_WORKFLOW_EXECUTION_STARTED, | ||
| nexusStartedEvent.getLinks(0).getWorkflowEvent().getEventRef().getEventType()); | ||
| } | ||
|
|
||
| public static class TestNexus implements TestWorkflows.TestWorkflow1 { | ||
| @Override | ||
| public String execute(String input) { | ||
| NexusOperationOptions options = | ||
| NexusOperationOptions.newBuilder() | ||
| .setScheduleToCloseTimeout(Duration.ofSeconds(10)) | ||
| .build(); | ||
| NexusServiceOptions serviceOptions = | ||
| NexusServiceOptions.newBuilder() | ||
| .setEndpoint(getEndpointName()) | ||
| .setOperationOptions(options) | ||
| .build(); | ||
| TestNexusServices.TestNexusService1 serviceStub = | ||
| Workflow.newNexusServiceStub(TestNexusServices.TestNexusService1.class, serviceOptions); | ||
| // Start an asynchronous operation backed by a workflow | ||
| NexusOperationHandle<String> asyncOpHandle = | ||
| Workflow.startNexusOperation(serviceStub::operation, input); | ||
| NexusOperationExecution asyncExec = asyncOpHandle.getExecution().get(); | ||
| // Signal the operation to unblock, this makes sure the operation doesn't complete before the | ||
| // operation | ||
| // started event is written to history | ||
| Workflow.newExternalWorkflowStub(OperationWorkflow.class, asyncExec.getOperationId().get()) | ||
| .unblock(); | ||
| return asyncOpHandle.getResult().get(); | ||
| } | ||
| } | ||
|
|
||
| @WorkflowInterface | ||
| public interface OperationWorkflow { | ||
| @WorkflowMethod | ||
| String execute(String arg); | ||
|
|
||
| @SignalMethod | ||
| void unblock(); | ||
| } | ||
|
|
||
| public static class TestOperationWorkflow implements OperationWorkflow { | ||
| boolean unblocked = false; | ||
|
|
||
| @Override | ||
| public String execute(String arg) { | ||
| Workflow.await(() -> unblocked); | ||
| return "Hello from operation workflow " + arg; | ||
| } | ||
|
|
||
| @Override | ||
| public void unblock() { | ||
| unblocked = true; | ||
| } | ||
| } | ||
|
|
||
| @ServiceImpl(service = TestNexusServices.TestNexusService1.class) | ||
| public class TestNexusServiceImpl { | ||
| @OperationImpl | ||
| public OperationHandler<String, String> operation() { | ||
| return WorkflowClientOperationHandlers.fromWorkflowMethod( | ||
| (context, details, client, input) -> | ||
| client.newWorkflowStub( | ||
| AsyncWorkflowOperationTest.OperationWorkflow.class, | ||
| WorkflowOptions.newBuilder().setWorkflowId(details.getRequestId()).build()) | ||
| ::execute); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bergundy is it fair to say their is no way to set this right now?