[#1727] Use default RetryOptions for LocalActivities when not set #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot set or setMaximumAttempts(0) Setting setMaximumAttempts=0 (or not setting any value, default = 0) for local activities should make the activity retry forever. This is currently broken because the logic treats both no policy set and a policy with all default values (including MaxiumAttempts = 0) as abort conditional. What should happen (at least according the doc and to align with normal activities) is that no policy set should be processed according to the default values of the retry policy, which includes unlimited retries when the MaxiumAttempts = 0. Fixes temporalio#1727 Signed-off-by: Greg Haskins <[email protected]>
|
Hey @ghaskins I know we discussed this a bit offline, but if we do want to change this we should add some tests (like the one in the reproduction you provided) that this change fixes. |
|
@Quinn-With-Two-Ns ok, I can take a stab at that. Normally I would have already submitted them but I was having trouble with the UT framework on my mac (most tests seem to be failing even with unmodified code). I'll see if I can sort that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting setMaximumAttempts=0 (or not setting any value, default = 0) for local activities should make the activity retry forever.
This is currently broken because the logic treats both no policy set and a policy with all default values (including MaxiumAttempts = 0) as abort conditional. What should happen (at least according the doc and to align with normal activities) is that no policy set should be processed according to the default values of the retry policy, which includes unlimited retries when the MaxiumAttempts = 0.
Fixes #1727