Nexus: Well know error translation #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporal-sdk/src/test/java/io/temporal/workflow/nexus/OperationFailureConversionTest.java
Outdated
Show resolved
Hide resolved
| @@ -59,7 +59,6 @@ private static String getMessage(WorkflowExecution execution, String workflowTyp | |||
| + execution.getWorkflowId() | |||
| + "', runId='" | |||
| + execution.getRunId() | |||
| + (workflowType == null ? "" : "', workflowType='" + workflowType + '\'') | |||
| + '}'; | |||
| + (workflowType == null ? "" : "', workflowType='" + workflowType + '\''); | |||
There was a problem hiding this comment.
Not sure what this random } was for
bergundy
reviewed
Oct 2, 2024
| throw new OperationHandlerException( | ||
| OperationHandlerException.ErrorType.INTERNAL, failure.getMessage()); | ||
| } | ||
| if (failure instanceof WorkflowException) { |
There was a problem hiding this comment.
Can you confirm that this roughly maps to WorkflowExecutionError or QueryRejectedError in Go?
This is fine as an initial first pass at this but I think eventually we may want a different approach. We'll see if we get any feedback on the current approach.
There was a problem hiding this comment.
WorkflowQueryException and WorkflowFailedException extend WorkflowException
There was a problem hiding this comment.
So they are both treated as BAD_REQUEST
bergundy
approved these changes
Oct 2, 2024
Quinn-With-Two-Ns
added a commit
that referenced
this pull request
Oct 3, 2024
Add conversion for common errors
Quinn-With-Two-Ns
added a commit
to Quinn-With-Two-Ns/sdk-java
that referenced
this pull request
Oct 11, 2024
Add conversion for common errors
Quinn-With-Two-Ns
added a commit
that referenced
this pull request
Oct 15, 2024
Add conversion for common errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate some well know errors like what we did with the Go SDK. This does not cover all possible SDK exception, just some we except users to throw in this initial release.
closes #2209