Add option to configure the deadline of getSystemInfo #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the issue reusing the health check timeout here? |
Yes the health check timeout is deprecated and it wasn't even using the timeout it was using the attempt timeout |
Quinn-With-Two-Ns
force-pushed
the
issue-2132
branch
from
1c40ae0
to
0ff1e30
Compare
cretz
approved these changes
Sep 25, 2024
Quinn-With-Two-Ns
added a commit
that referenced
this pull request
Sep 25, 2024
Add get system info timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to configure the deadline of getSystemInfo like the Go SDK has
closes #2132