Add more docs

temporalio · Apr 15, 2024 · a6bc7c8 · a6bc7c8
1 parent 1155066
commit a6bc7c8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/gradle/java.gradle b/gradle/java.gradle
@@ -6,8 +6,8 @@ subprojects {
 
     java {
         // graal only supports java 8, 11, 16, 17, 21
-        sourceCompatibility = project.hasProperty("edgeDepsTest") ? JavaVersion.VERSION_21 : JavaVersion.VERSION_21
-        targetCompatibility = project.hasProperty("edgeDepsTest") ? JavaVersion.VERSION_21 : JavaVersion.VERSION_21
+        sourceCompatibility = project.hasProperty("edgeDepsTest") ? JavaVersion.VERSION_21 : JavaVersion.VERSION_1_8
+        targetCompatibility = project.hasProperty("edgeDepsTest") ? JavaVersion.VERSION_21 : JavaVersion.VERSION_1_8
         withJavadocJar()
         withSourcesJar()
     }
@@ -24,10 +24,10 @@ subprojects {
     compileTestJava {
         options.encoding = 'UTF-8'
         options.compilerArgs << '-Xlint:none' << '-Xlint:deprecation' << '-Werror' << '-parameters'
-//        if (JavaVersion.current().isJava9Compatible() && !project.hasProperty("edgeDepsTest")) {
-//            // https://stackoverflow.com/a/43103115/525203
-//            options.compilerArgs.addAll(['--release', '8'])
-//        }
+        if (JavaVersion.current().isJava9Compatible() && !project.hasProperty("edgeDepsTest")) {
+            // https://stackoverflow.com/a/43103115/525203
+            options.compilerArgs.addAll(['--release', '8'])
+        }
     }
 
     javadoc {

diff --git a/temporal-sdk/src/main/java/io/temporal/worker/WorkerFactoryOptions.java b/temporal-sdk/src/main/java/io/temporal/worker/WorkerFactoryOptions.java
@@ -21,6 +21,7 @@
 package io.temporal.worker;
 
 import com.google.common.base.Preconditions;
+import io.temporal.common.Experimental;
 import io.temporal.common.interceptors.WorkerInterceptor;
 import java.time.Duration;
 import javax.annotation.Nullable;
@@ -121,6 +122,15 @@ public Builder setEnableLoggingInReplay(boolean enableLoggingInReplay) {
       return this;
     }
 
+
+    /**
+     * Enable the use of Virtual Threads for workflow execution across all workers created by
+     * this factory. This includes cached workflows. This option is only supported for JDK >= 21.
+     * If set then {@link #setMaxWorkflowThreadCount(int)} is ignored.
+     *
+     * <p>Default is false
+     */
+    @Experimental
     public Builder setEnableVirtualThreads(boolean enableVirtualThreads) {
       this.enableVirtualThreads = enableVirtualThreads;
       return this;
@@ -208,6 +218,7 @@ public int getMaxWorkflowThreadCount() {
     return maxWorkflowThreadCount;
   }
 
+  @Experimental
   public boolean isEnableVirtualThreads() {
     return enableVirtualThreads;
   }