Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test to validate temporal_workflow_task_execution_failed on replay #1669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuandrew
Copy link
Contributor

What was changed

Added a new test to test the temporal_workflow_task_execution_failed metric is logged when replaying a closed workflow hits NDE.

Why?

This metric failed to log in 1.26.0, but does today. Add a test to monitor for a regression with this behavior.

Checklist

  1. Closes temporal_workflow_task_execution_failed not emitted on replay #1441

  2. How was this tested:

New integration test passes
3. Any docs updates needed?

@yuandrew yuandrew requested a review from a team as a code owner October 11, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

temporal_workflow_task_execution_failed not emitted on replay
1 participant