Nexus: Fix link not being attached to a workflow started via a Handler function #1659
Conversation
temporalnexus/operation.go
Outdated
| @@ -262,11 +252,14 @@ type WorkflowHandle[T any] interface { | |||
| ID() string | |||
| // ID is the workflow's run ID. | |||
| RunID() string | |||
| // Link to the WorkflowExecutionStarted event of the workflow represented by this handle. | |||
| Link() nexus.Link | |||
There was a problem hiding this comment.
hm why does this need to be on the interface? Are users expected to use this method?
There was a problem hiding this comment.
It doesn't but I don't think it hurts.
Another approach would be to put this on the struct implementation and have an unexported method on the interface to ensure users don't try to implement it. This is important since the handler's return value is the interface.
There was a problem hiding this comment.
I'll change to that alternative.
|
I understand if we can't write an end to end test for this, but what is stopping us from unit testing this change? |
We'll add integration tests soon. server |
Not testing this since server 1.25.0 didn't get support for links.