MultiOperation retry non-durable Update #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
multiops-retry
branch
from
68a65db
to
a29a318
Compare
stephanos
force-pushed
the
multiops-retry
branch
from
a29a318
to
ed0c128
Compare
cretz
reviewed
Sep 30, 2024
| return nil, fmt.Errorf("%w: %T", errUnsupportedOperation, t) | ||
| } | ||
| } | ||
| return nil, startErr |
There was a problem hiding this comment.
Can startErr be nil here? Even if server-side contract guarantees not, we might as well set a default somehow.
There was a problem hiding this comment.
Right, if the server misbehaves, it could be nil. I'll set a default 👍
Quinn-With-Two-Ns
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
I noticed these shortcomings when implementing the Java SDK.
Checklist
Closes ExecuteMultiOperation is not retrying non-admitted Updates #1635
How was this tested: added new tests
Any docs updates needed?