Reassign runningWorkflows workflow ID in test environment #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 17, 2023
| // Reassign the ID in running Workflows so SignalWorkflowByID can find the workflow | ||
| originalID := wf.WorkflowExecution.ID | ||
| env.runningWorkflows[options.ID] = env.runningWorkflows[wf.WorkflowExecution.ID] | ||
| delete(env.runningWorkflows, originalID) |
There was a problem hiding this comment.
I was originally thinking maybe we wanted to also leave it in the map under the original ID, but if someone is referring to it by original ID in their tests even after setting w/ a new ID, I think they can be asked to fix their tests. Thoughts?
There was a problem hiding this comment.
yeah I think it is a reasonable to ask they fix their test
Quinn-With-Two-Ns
force-pushed
the
1160-XByID
branch
from
c58187b
to
7df44bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the runningWorkflows map with the specified ID if set
closes: #1160