Use workflow init from samples #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ packages = [ | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.8" | |||
| temporalio = "^1.7.0" | |||
| temporalio = { path = "../sdk-python" } | |||
There was a problem hiding this comment.
Cannot be committed now. Needs to await the released Python SDK having Workflow Init support.
cretz
reviewed
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Workflow Init is a brand new feature.
Let's show people best practices for each sample that uses a signal or update handler and receives workflow arguments.
Why?
These changes make sure these workflows are initialized before signal or update handlers are run.
Checklist
Closes
How was this tested:
Automated:
poetry run pytest workflow_test.pyManual:
Follow instructions in
bedrock/entity/README.mdand
message_passing/safe_message_handlers/README.md