Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patching sample #80

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Patching sample #80

merged 7 commits into from
Aug 21, 2024

Conversation

jakejscott
Copy link
Contributor

What was changed

Added sample for Patching

Why?

Because there was an open issue for it :)

Checklist

  1. Closes Sample request: Patching #66

  2. How was this tested:
    Manually copy pasting each command from the samples README

  3. Any docs updates needed?
    I've updated the repo README.

cretz
cretz reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Only one slight request of turning that Result to a property and there's a CI issue w/ spacing, but then happy to merge as is. It all reads very well.

src/Patching/MyWorkflow1Initial.workflow.cs Outdated Show resolved Hide resolved
src/Patching/README.md Show resolved Hide resolved
cretz
cretz approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@cretz
Copy link
Member

cretz commented Aug 20, 2024

Oh, it looks like there is a conflict with the sln file. Can you merge main, use main's sln file, then re dotnet sln add this project to fix the conflict?

@jakejscott
Merge branch 'main' into patching
2ddc941 
# Conflicts:
#	TemporalioSamples.sln
@cretz cretz merged commit 30bbd97 into temporalio:main Aug 21, 2024
6 checks passed
@cretz
Copy link
Member

cretz commented Aug 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample request: Patching
2 participants
@jakejscott @cretz