Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes AesGcm Sample Thread Safe #52

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Makes AesGcm Sample Thread Safe #52

merged 7 commits into from
Feb 12, 2024

Conversation

joelrozen
Copy link
Contributor

What was changed

Changed Encryption Codec in Encryption Sample to use a new instance of AesGcm on each call.

Why?

See #50

Checklist

  1. Closes [Bug] AesGcm instance should not be reused in EncryptionCodec #50

  2. How was this tested:

Ran several thousand simultaneous workflows
  1. Any docs updates needed? No

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of suggestions but otherwise looks good.

src/Encryption/Codec/EncryptionCodec.cs Outdated Show resolved Hide resolved
src/Encryption/Codec/EncryptionCodec.cs Outdated Show resolved Hide resolved
src/Encryption/Codec/EncryptionCodec.cs Outdated Show resolved Hide resolved
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a compile error to fix.

src/Encryption/Codec/EncryptionCodec.cs Outdated Show resolved Hide resolved
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI still not passing, a couple of typos. Run dotnet build to confirm it builds.

src/Encryption/Codec/EncryptionCodec.cs Outdated Show resolved Hide resolved
src/Encryption/Codec/EncryptionCodec.cs Outdated Show resolved Hide resolved
@joelrozen
Copy link
Contributor Author

image

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cretz cretz merged commit a815d92 into temporalio:main Feb 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants