Document workflow.init for Python #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
python-workflow-init
branch
from
1e124f3
to
649e2a1
Compare
dandavison
force-pushed
the
python-workflow-init
branch
2 times, most recently
from
cd29aed
to
b40bb93
Compare
dandavison
force-pushed
the
python-workflow-init
branch
from
b40bb93
to
f77a9c7
Compare
dandavison
commented
Sep 30, 2024
dandavison
commented
Sep 30, 2024
dandavison
force-pushed
the
python-workflow-init
branch
from
7a93dbb
to
2b180d0
Compare
dandavison
commented
Oct 1, 2024
fairlydurable
added
the
blocked-on-release
|
Continuous Integration will not build until /encyclopedia/workflow-message-passing#workflow-initializers is available, which is @drewhoskins-temporal 's ticket/PR. |
fairlydurable
approved these changes
Oct 9, 2024
dandavison
force-pushed
the
python-workflow-init
branch
from
6aecfa0
to
e579e01
Compare
|
Thanks @drewhoskins-temporal pushed fixes for both of those, and I also changed the example to make it wait for the update (sample). |
|
@dandavison So what is the status given those fixes and updates? Merge now? Wait? Thanks |
No, this still can't be merged until next Python SDK release. I'll notify when that occurs. |
|
Moved to "Pending Release" column on board. |
fairlydurable
removed
the
blocked-on-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document
@workflow.init, added in temporalio/sdk-python#645.Notes to reviewers: