Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-PHP: Add Features/Side Effects block #2145

Closed
wants to merge 3 commits into from

Conversation

roxblnfk
Copy link
Contributor

What does this PR do?

The PR adds Features / Side Effects block with code sample (see #1789)

@roxblnfk roxblnfk requested a review from a team as a code owner June 27, 2023 12:47
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few wording changes. Overall structure is good 👍

docs/dev-guide/phplang/features.md Outdated Show resolved Hide resolved
docs/dev-guide/phplang/features.md Outdated Show resolved Hide resolved
docs/dev-guide/phplang/features.md Outdated Show resolved Hide resolved
docs/dev-guide/phplang/features.md Outdated Show resolved Hide resolved
@roxblnfk
Copy link
Contributor Author

roxblnfk commented Jul 6, 2023

A few wording changes

@Sushisource I copied that text from Java documentation. Should I fix the same in Java docs in another PR?

@Sushisource
Copy link
Member

@roxblnfk That would be great, or the docs folks can do it too, I'll get them to comment here.

@rachfop
Copy link
Contributor

rachfop commented Jul 25, 2023

#2225

Added the content here in the docs if I could get an approval.

@rachfop
Copy link
Contributor

rachfop commented Jul 26, 2023

@rachfop rachfop closed this Jul 26, 2023
@roxblnfk roxblnfk deleted the sdk-php/features branch July 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants