-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning3 proto updates for data plane APIs #463
Merged
+115
−8
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -347,6 +347,15 @@ message RespondWorkflowTaskCompletedRequest { | |
// always be set by SDKs. Workers opting into versioning will also set the `use_versioning` | ||
// field to true. See message docstrings for more. | ||
temporal.api.common.v1.WorkerVersionStamp worker_version_stamp = 10; | ||
// Versioning behavior explicitly specified by user for this workflow type. | ||
// If absent, `default_versioning_behavior` will be used. | ||
// At least one of `versioning_behavior` or `default_versioning_behavior` should be set when | ||
// `worker_version_stamp.use_versioning` is `true` and `worker_version_stamp.deployment_name` is | ||
// provided (which means versioning-3 API is used). | ||
temporal.api.enums.v1.VersioningBehavior versioning_behavior = 14; | ||
// Default versioning behavior that is set at worker server level. | ||
temporal.api.enums.v1.VersioningBehavior default_versioning_behavior = 15; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Asking SDK to send both explicit and default annotations so we can have visibility on what/how users set these. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
// Default versioning behavior that is set at worker server level. | ||
// Protocol messages piggybacking on a WFT as a transport | ||
repeated temporal.api.protocol.v1.Message messages = 11; | ||
// Data the SDK wishes to record for itself, but server need not interpret, and does not | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Auto-upgrade" behavior seemed a better name than "unpinned". But we can change the name later when namings are final. cc @drewhoskins-temporal @antlai-temporal