Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document failover version #377

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Document failover version #377

wants to merge 2 commits into from

Conversation

dandavison
Copy link
Contributor

No description provided.

@dandavison dandavison requested review from a team as code owners March 21, 2024 13:22
bergundy
bergundy reviewed Mar 21, 2024
View reviewed changes
temporal/api/history/v1/message.proto
Comment on lines +770 to +771
// Namespace failover version. Defines alternate history branches that can arise in
// multi-cluster configurations (e.g. multi-region namespaces).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not catching this earlier.
We refer to them global namespaces not multi-region so might want to adjust.

Suggested change
// Namespace failover version. Defines alternate history branches that can arise in
// multi-cluster configurations (e.g. multi-region namespaces).
// Namespace failover version. Defines alternate history branches that can arise in
// multi-cluster configurations (e.g. global namespaces).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dandavison @bergundy @cretz