Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage info to README #238

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add usage info to README #238

wants to merge 2 commits into from

Conversation

lorensr
Copy link
Contributor

@lorensr lorensr commented Sep 23, 2022

No description provided.

@lorensr lorensr requested review from a team as code owners September 23, 2022 22:01

## How to use
Proto files describing our gRPC API. Implemented by [Temporal Server](https://github.com/temporalio/temporal) and used by the [SDKs](https://docs.temporal.io/temporal#temporal-sdk) (both Clients and Workers).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Temporal gRPC API"?
And not "describing", but "defining". I wish they described a little more.


### With code

Usually you interact with the API via high-level SDK methods like `startWorkflow()`. However, Clients also expose the underlying gRPC services, like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use "Service Clients"? "Clients" is a bit of a general term.


Usually you interact with the API via high-level SDK methods like `startWorkflow()`. However, Clients also expose the underlying gRPC services, like:

- [`Client.connection.workflowService`](https://typescript.temporal.io/api/classes/client.connection/#workflowservice)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add links to the corresponding way to get a raw grpc client in other languages?

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor talking points.

README.md Outdated

### Via REST

See [`temporalio/ui-server`](https://github.com/temporalio/ui-server)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to promote this as an API server unless it's offering compatibility guarantees. Instead we should be putting HTTP annotations on these protos.


### With code

Usually you interact with the API via high-level SDK methods like `startWorkflow()`. However, Clients also expose the underlying gRPC services, like:
Copy link
Member

@cretz cretz Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to either: 1) put every SDK's approach to raw gRPC invocation in here, or 2) put every SDK's approach to raw gRPC invocation somewhere and link to it from here.


Install as git submodule to the project.
- [Use the API](#use-the-api)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TOC expected to be manually maintained? In GH, the TOC is already available at the top-left of the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants