Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#747 | decode trx input to show contract function call #759

Merged
merged 4 commits into from
May 31, 2024

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented May 27, 2024

Fixes #747

Deployment

Description

This PR includes the solution for two of the three views that the new TransactionInputViewer component should offer. The Default view requires a refinement of the algorithms, so it was separated in this issue (#762) and will be scheduled apart.

The two views implemented are:

  • Original: is the input as plain text
  • Decoded: Is the Table with all parameters' types and values.

Test Scenarios

@Viterbo Viterbo self-assigned this May 27, 2024
Copy link

netlify bot commented May 27, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit bd3c5cf
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/66573302c58b8a0008d78896
😎 Deploy Preview https://deploy-preview-759--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit bd3c5cf
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/665733028e1b370008d801af
😎 Deploy Preview https://deploy-preview-759--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit bd3c5cf
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/66573302211f5e0008e2dd5b
😎 Deploy Preview https://deploy-preview-759--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmjanus pmjanus marked this pull request as draft May 28, 2024 17:41
@Viterbo Viterbo marked this pull request as ready for review May 28, 2024 22:01
@pmjanus
Copy link
Contributor

pmjanus commented May 28, 2024

image We need the decoded view to allow for copy paste of values, it should all be visible or scrollable, I think you can try to make font smaller or have the input take more than one line.

@Viterbo
Copy link
Collaborator Author

Viterbo commented May 29, 2024

I changed the table to show multiline text on value cell.
Also added a copy to clipboard button on the top-right corner of the table.
image

@Viterbo Viterbo marked this pull request as draft May 29, 2024 14:16
@Viterbo
Copy link
Collaborator Author

Viterbo commented May 29, 2024

Copy to clipboard by line:

image

Fixed mobile design:

image

@Viterbo Viterbo marked this pull request as ready for review May 29, 2024 14:28
@pmjanus pmjanus merged commit f34dccf into dev May 31, 2024
13 checks passed
@pmjanus pmjanus deleted the 747-decode-trx-input-to-show-contract-function-call branch May 31, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants