GetTableRowsParams fixes, endianess for 256 key for RSDK and GetBlockResult deserialization #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
guilledk
force-pushed
the
finish_table_rows_params
branch
2 times, most recently
from
b38184d
to
4a0ed13
Compare
guilledk
force-pushed
the
finish_table_rows_params
branch
from
4a0ed13
to
c8d60b2
Compare
…ks for rscdk compiled contracts" This reverts commit 6977b8b, in particular the endianness of Checksum256. This is needed to be compatible with the C++ smart contracts compiler, while rscdk (Rust WASM compiler) needs the commit that here is being reverted. This means that going on antelope-rs will be compatible with the C++ smart contracts compiler and not with the Rust compiler.
The test was meant to check the consistency of the Checksum256 encoding with the SNARKtor contracts and the WASM-compiled smart contracts in general. However, given that the `rscdk` compiler treats the encoding of Checksum256 with a different encoding compared to the C++ compiler, the test has been removed. It could be restored once the `rscdk` issue is fixed.
3 tasks
ptagl
approved these changes
Sep 11, 2024
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.