CHI-2763 Check for an active contact & complete task #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythilytm
changed the title
6 tasks
GPaoloni
approved these changes
Oct 4, 2024
functions/checkTaskAssignment.ts
Outdated
| taskSid, | ||
| }); | ||
|
|
||
| console.log('>>> checkTaskStatus Result:', result); |
There was a problem hiding this comment.
Remove this logs before merging? Or keep it a while but let's remember to cleanup at some point.
| action: 'complete'; | ||
| taskSid: string; | ||
| targetSid: string; | ||
| finalTaskAttributes: TaskInstance['attributes']; |
There was a problem hiding this comment.
Where do this finalTaskAttributes come from? 🤔 Is that from the supervisor Flex instance? If so, how are those computed? (Maybe I'll answer this question after reviewing the other PR).
Comment on lines
+101
to
+111
| if (!token || token === undefined) { | ||
| resolve(error400('token')); | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| const tokenResult: TokenValidatorResponse = await validator( | ||
| token as string, | ||
| accountSid, | ||
| authToken, | ||
| ); |
There was a problem hiding this comment.
This all looks great, but have you checked if tokenResult is not included in the event?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new public functions:|
checkTaskAssignment.tsthat checks whether a specific call/chat (identified by taskSid) is active.completeTaskAssignment.tsallows a supervisor to switch the assignment status to complete a task.Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P