CHI-1260: Deploy all prod workflow #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at uses the generic one. Removed need to specify environment twice in a custom workflow
…rkflow - to be able to test without merging
…to use deploy-multiple-accounts.yml
murilovmachado
approved these changes
Aug 29, 2023
Comment on lines
+1
to
+3
| [ | ||
| "AS" | ||
| ] |
There was a problem hiding this comment.
You have only AS here for testing, but eventually, we'll list them all, correct?
There was a problem hiding this comment.
Yes, sorry, should have explained in the PR it's the old chicken & egg problem, shouldn't merge the PR before it's tested but can't test the new workflow without it being merged
There was a problem hiding this comment.
Yes, sorry should have noted that on the PR
The old 'chicken & egg' problem that we shouldn't merge before we test but the new workflow can't be tested before it's merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issues
CHI-1260
Verification steps