chore: address feedback around admin reindex endpoints #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts based off contacts
…acts [CHI-2724] (#645)
…CHI-2760-reindex-script
* feat: build script for reindexing contacts and cases * change options for indexing * sqs debug * revert logs * modify to have more graceful error handling for user * modify to have more graceful error handling for user * modify to have more graceful error handling for user --------- Co-authored-by: Gianfranco Paoloni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a followup to the chain #651 -> #652 -> #648.
I'm addressing (most of) the feedback left in those PRs here, cause this is easier than addressing (more) merge conflicts 😝
In this PR:
autoPaginateand related utilities to a new module,@tech-matters/batch-processingthat you can find under/packages//batch-processing, as suggested.admin-cli:reindex:hrmnow supports - TODO -Checklist
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P