Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: General Search Date Filters behavior [CHI-2978] #2550

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

GPaoloni
Copy link
Collaborator

@GPaoloni GPaoloni commented Sep 27, 2024

Description

This PR

  • Uses endOfDay helper before sending dateTo filter to the service. This changes the behavior to be an "inclusive" filter.
  • Changes UI validation, to prevent invalid dates to allow submission.

Checklist

Verification steps

Bugs described in the Jira ticket are not replicable.

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@GPaoloni GPaoloni changed the title fix: General Search Date Filters behavior [CHI-2978 fix: General Search Date Filters behavior [CHI-2978] Sep 27, 2024
@GPaoloni GPaoloni marked this pull request as ready for review September 27, 2024 22:06
@GPaoloni GPaoloni merged commit 3fe5e57 into master Sep 30, 2024
8 checks passed
@GPaoloni GPaoloni deleted the gian_CHI-2978 branch September 30, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants