Rework arm implementation and API #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesmackenzie
force-pushed
the
arm-rework
branch
from
9d608c6
to
1c2dd4c
Compare
jkleiber
reviewed
Dec 13, 2023
There was a problem hiding this comment.
To avoid merge conflicts, I would just delete this file since @redPlover is deleting it
There was a problem hiding this comment.
probably should delete this file since @redPlover is deleting it in his branch
There was a problem hiding this comment.
Probably best to delete this one too since it's being deleted in #35
There was a problem hiding this comment.
this file is being deleted in #35 and isn't related to the arm - best move is to revert all changes or delete it to avoid merge conflicts
| private final WristSubsystem wrist = new WristSubsystem(); | ||
| private final IntakeSubsystem intake = new IntakeSubsystem(); | ||
| // private final Drive drive = new Drive(); | ||
| private final ArmSubsystem arm; |
There was a problem hiding this comment.
It looks like ArmSubsystem has been deleted, so it isn't clear how this will work
charlesmackenzie
force-pushed
the
arm-rework
branch
from
6e403ef
to
860de98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to address the first part of #31 by aggressively refactoring the arm code. Changes focus on understandably and straightforwardness.
Need to do:
Add some unit tests?Thismightwill become another PRNotes:
AdvantageKit implementation will take place in another PR.YOLO