Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve names and reduce line buffer size #312

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

vbaderks
Copy link
Contributor

@vbaderks vbaderks commented Aug 2, 2024

  • Move constant values that are only used once to the method that uses these constant values (reduces scope)
  • Rename context_regular_mode to regular_mode_context and context_run_mode to run_mode_context
  • Reduce the line buffer from 4 extra items to 2 (2 are needed for the borders).
  • Replace dynamic run_index buffer with static buffer (max size is only 4 items)

- Move constant values that are only used once to the method that uses these constant values (reduces scope)
- Rename context_regular_mode to regular_mode_context and context_run_mode to run_mode_context
- Reduce the line buffer from 4 extra items to 2 (2 are needed for the borders).
- Replace dynamic run_index buffer with static buffer (max size is only 4 items)
Copy link

sonarcloud bot commented Aug 2, 2024

@vbaderks vbaderks merged commit 1460f8d into main Aug 2, 2024
32 checks passed
@vbaderks vbaderks deleted the small-improvements branch August 2, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant