Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty cells covering overflowing text of left cell #821

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

knubix
Copy link
Contributor

@knubix knubix commented Sep 19, 2024

Solving following issue:
I am reading a sheet from an existing xlsx file with ValueOnly() and replacing some spaceholder strings with ForEachRow and ForEachCell with SkipEmptyRows and SkipEmptyCells as parameters. Saving the results Save() serializes the xlsx file into file, with empty cells covering my celloverflowing replacements.

The actual code skips only empty rows. This pull request adds the SkipEmptyCells to ForEachCell during serialization and avoids unnecessary cells.

…l; avoid unnecessary empty cells in final sheet covering longer cells left of them
Copy link
Owner

@tealeg tealeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 like it!

@tealeg tealeg merged commit cbf4534 into tealeg:master Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants