fix: Fix wrong references number

Signed-off-by: Adam Tao <[email protected]>
tcx4c70 · Mar 27, 2024 · b38c8ad · b38c8ad
1 parent 4b57c5f
commit b38c8ad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Handlers/CodeLens.fs b/src/Handlers/CodeLens.fs
@@ -169,9 +169,11 @@ module CodeLens =
         | None -> return p |> success
         | Some symbol ->
             let! refs = wm.FindReferences symbol
-            // FIXME: refNum is wrong. There are lots of false positive even if we distinct locations by
-            // (l.Location.SourceTree.FilePath, l.Location.SourceSpan)
-            let refNum = refs |> Seq.map (fun r -> r.Locations |> Seq.length) |> Seq.fold (+) 0
+            let refNum =
+                refs
+                |> Seq.collect (fun r -> r.Locations)
+                |> Seq.distinctBy (fun l -> (l.Location.SourceTree.FilePath, l.Location.SourceSpan))
+                |> Seq.length
             let title = sprintf "%d Reference(s)" refNum
 
             let arg: ReferenceParams =

diff --git a/src/Handlers/References.fs b/src/Handlers/References.fs
@@ -36,11 +36,11 @@ module References =
         | None -> return None |> success
         | Some symbol ->
             let! refs = wm.FindReferences symbol
-            // FIXME: refs is wrong. There are lots of false positive even if we add Seq.distinct before Seq.toArray
             return
                 refs
                 |> Seq.collect (fun r -> r.Locations)
                 |> Seq.map (fun rl -> Location.fromRoslynLocation rl.Location)
+                |> Seq.distinct
                 |> Seq.toArray
                 |> Some
                 |> success