Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only run when python files changed, update docs #8

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

only run when python files changed, update docs #8

wants to merge 17 commits into from

Conversation

valentijnscholten
Copy link

the check was failing if there were no python files changed by the PR
also the docs were still referring to the old main.workflow definitions from GitHub actions early days

@valentijnscholten
Copy link
Author

fixes #2 #3 #5 #6 #7

@valentijnscholten
Copy link
Author

this PR was meant for my own fork, but github defaults to the parent repo apparently so I'll just leave it here.

@rickstaa
Copy link

rickstaa commented Nov 2, 2020

@valentijnscholten I'm currently on your fork as it solves this problem. Thanks a lot for that. Maybe it is an idea to create a pull request containing the fixes you made on your master branch such that they are solved in the upstream repository?

@valentijnscholten
Copy link
Author

I've merged my master into this branch. Not really production ready, due to the debug logging but it's a start.

@rickstaa
Copy link

rickstaa commented Nov 3, 2020

@valentijnscholten Thanks a lot! I will base my action on your branch for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentijnscholten @rickstaa