Refactored headerRows usage

taitems · Mar 16, 2015 · 685d5fa · 685d5fa
1 parent 3a0028d
commit 685d5fa
Showing 1 changed file with 21 additions and 16 deletions.
diff --git a/js/jquery.fn.gantt.js b/js/jquery.fn.gantt.js
@@ -257,8 +257,10 @@
             // **Render the grid**
             render: function (element) {
                 var content = $('<div class="fn-content"/>');
+
                 var $leftPanel = core.leftPanel(element);
                 content.append($leftPanel);
+
                 var $rightPanel = core.rightPanel(element, $leftPanel);
                 var mLeft, hPos;
 
@@ -320,7 +322,6 @@
                 /* Left panel */
                 var ganttLeftPanel = $('<div class="leftPanel"/>')
                     .append($('<div class="row spacer"/>')
-                    .css("height", tools.getCellSize() * element.headerRows + "px")
                     .css("width", "100%"));
 
                 var entries = [];
@@ -409,7 +410,7 @@
 
             // Creates and return the right panel containing the year/week/day
             // header
-            rightPanel: function (element, leftPanel /* <- never used? */) {
+            rightPanel: function (element, $leftPanel) {
 
                 var range = null;
                 // Days of the week have a class of one of
@@ -433,6 +434,8 @@
                 var horArr = [];
 
 
+                var headerRows = null;
+
                 var today = new Date();
                 today = new Date(today.getFullYear(), today.getMonth(), today.getDate());
 
@@ -552,6 +555,8 @@
                         dataPanel.append($('<div class="row"/>').html(dowArr.join("")));
                         dataPanel.append($('<div class="row"/>').html(horArr.join("")));
 
+                        headerRows = 5;
+
                         break;
 
                     // **Weeks**
@@ -617,6 +622,8 @@
 
                         dataPanel.append(yearArr.join("") + monthArr.join("") + dayArr.join("") + (dowArr.join("")));
 
+                        headerRows = 3;
+
                         break;
 
                     // **Months**
@@ -668,6 +675,8 @@
                         dataPanel.append($('<div class="row"/>').html(dayArr.join("")));
                         dataPanel.append($('<div class="row"/>').html(dowArr.join("")));
 
+                        headerRows = 2;
+
                         break;
 
                     // **Days (default)**
@@ -746,9 +755,14 @@
                         dataPanel.append($('<div class="row" style="margin-left: 0;" />').html(dayArr.join("")));
                         dataPanel.append($('<div class="row" style="margin-left: 0;" />').html(dowArr.join("")));
 
+                        headerRows = 4;
+
                         break;
                 }
 
+                // update height of spacer element
+                $leftPanel.find('.spacer').css("height", tools.getCellSize() * headerRows + "px")
+
                 return $('<div class="rightPanel"></div>').append(dataPanel);
             },
 
@@ -1226,30 +1240,23 @@
                     var scaleSt = element.scaleStep + val * 3;
                     scaleSt = scaleSt <= 1 ? 1 : scaleSt === 4 ? 3 : scaleSt;
                     var scale = settings.scale;
-                    var headerRows = element.headerRows;
                     if (settings.scale === "hours" && scaleSt >= 13) {
                         scale = "days";
-                        headerRows = 4;
                         scaleSt = 13;
                     } else if (settings.scale === "days" && zoomIn) {
                         scale = "hours";
-                        headerRows = 5;
                         scaleSt = 12;
                     } else if (settings.scale === "days" && !zoomIn) {
                         scale = "weeks";
-                        headerRows = 3;
                         scaleSt = 13;
                     } else if (settings.scale === "weeks" && !zoomIn) {
                         scale = "months";
-                        headerRows = 2;
                         scaleSt = 14;
                     } else if (settings.scale === "weeks" && zoomIn) {
                         scale = "days";
-                        headerRows = 4;
                         scaleSt = 13;
                     } else if (settings.scale === "months" && zoomIn) {
                         scale = "weeks";
-                        headerRows = 3;
                         scaleSt = 13;
                     }
 
@@ -1260,7 +1267,6 @@
                     }
                     element.scaleStep = scaleSt;
                     settings.scale = scale;
-                    element.headerRows = headerRows;
                     var $rightPanel = $(element).find(".fn-gantt .rightPanel");
                     var $dataPanel = $rightPanel.find(".dataPanel");
                     element.hPosition = $dataPanel.css("margin-left").replace("px", "");
@@ -1717,7 +1723,6 @@
             this.dateEnd = null;
             this.scrollClicked = false;
             this.scaleOldWidth = null;
-            this.headerRows = null;
 
             // Update cookie with current scale
             if (settings.useCookie) {
@@ -1730,11 +1735,11 @@
             }
 
             switch (settings.scale) {
-                //case "hours": this.headerRows = 5; this.scaleStep = 8; break;
-                case "hours": this.headerRows = 5; this.scaleStep = 1; break;
-                case "weeks": this.headerRows = 3; this.scaleStep = 13; break;
-                case "months": this.headerRows = 2; this.scaleStep = 14; break;
-                default: this.headerRows = 4; this.scaleStep = 13; break;
+                //case "hours": this.scaleStep = 8; break;
+                case "hours": this.scaleStep = 1; break;
+                case "weeks": this.scaleStep = 13; break;
+                case "months": this.scaleStep = 14; break;
+                default: this.scaleStep = 13; break;
             }
 
             this.scrollNavigation = {