Consistent (SAX/DOM) wrapping of XML parse errors #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic that chooses wrapping SQLException subclass and SQLstate for XML parse exceptions and I/O exceptions in XMLCopier.saxCopy is now duplicated in AdjustingDOMSource.get. Addresses issue #481.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic that chooses wrapping
SQLExceptionsubclass andSQLstatefor XML parse exceptions and I/O exceptions inXMLCopier.saxCopyis now duplicated inAdjustingDOMSource.get, to eliminate the inconsistency that an XML parse error would be reported as a class 22SQLDataExceptionif using the SAX or StAX APIs, but as a class XX internal-errorSQLExceptionif using the DOM API.Addresses issue #481.
This does change a user-visible behavior. It would be straightforward to make it depend on a flag, if there exists any code depending on the prior behavior. (I am judging that unlikely.)