Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: docstrings for user item and endpoint #1485

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

jorwoods
Copy link
Contributor

@jorwoods jorwoods commented Oct 3, 2024

No description provided.

Copy link
Contributor

@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Are you doing it manually? We do have most of this in the REST docs.

@jorwoods
Copy link
Contributor Author

jorwoods commented Oct 4, 2024

Its a mix of copying information in from https://tableau.github.io/server-client-python/docs/api-ref, https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref.htm, and adding some extra detail where appropriate. The main thing I'm unsure of is detailing all of the ServerResponseError codes and details or if it should just point them to the server REST API docs for that detail.

@jorwoods
Copy link
Contributor Author

jorwoods commented Oct 4, 2024

The reason for pulling this info into docstrings from the docs is if we go forward with the rewrite per #1451, then we could pull the docstrings in as the documentation. Making it available both in the web and in the IDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants