-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exceptions): separate failed signin error #1478
base: development
Are you sure you want to change the base?
Conversation
878e813
to
74f7797
Compare
@bcantoni I made a tweak to how the ServerInfoItem does its error handling to raise the error immediately. It currently raises a |
I also changed the log level on those messages from info to exception so that they'll bubble up more clearly in logs. |
Closes tableau#1472 This makes sign in failures their own class of exceptions, while still inheriting from NotSignedInException to not break backwards compatability for any existing client code. This should allow users to get out more specific exceptions more easily on what failed with their authentication request.
If ServerInfoItem.from_response gets invalid XML, raise the error immediately instead of suppressing the error and setting an invalid version number
388d1bd
to
6eab3c9
Compare
Did some quick testing and this change looks good. Sign in with incorrect PAT, before:
Sign in with incorrect PAT, after:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought I don't think we need to do anything specific for 1450 (no specific error for pointing to a non-Tableau server).
Do you want it to raise the NonXMLResponseError? Or should I revert that change? |
Closes #1472
This makes sign in failures their own class of exceptions, while still inheriting from NotSignedInException to not break backwards compatability for any existing client code. This should allow users to get out more specific exceptions more easily on what failed with their authentication request.