Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version of setup-python action #1237

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

lukewrites
Copy link
Member

@lukewrites lukewrites commented May 23, 2024

GitHub Actions now has Mac ARM runners! This is how we found out:

  1. The version of setup-python we were using doesn't work on Apple Si runners
  2. some of our unit tests were borked on Apple Si

This PR updates the action and also fixes the unit tests.

Fixing here

@pep8speaks
Copy link

Thanks for updating the PR.

Line 409:121: E501 line too long (129 > 120 characters)
Line 386:121: E501 line too long (134 > 120 characters)
Line 372:121: E501 line too long (134 > 120 characters)
Line 362:121: E501 line too long (134 > 120 characters)
Line 347:121: E501 line too long (134 > 120 characters)

Copy link
Contributor

@pvanderknyff pvanderknyff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@lukewrites lukewrites merged commit ee1d09a into master May 24, 2024
19 checks passed
@lukewrites lukewrites deleted the update-actions-version branch May 24, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants