[WIP] Add dither struct and select texture based on the pass #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Jun 21, 2018
| } | ||
|
|
||
| pub fn get(&self) -> &Texture { | ||
| if self.in_main_framebuffer_pass { |
There was a problem hiding this comment.
why does this only apply to the main framebuffer? I'd expect it to be a general difference in the rendering coordinate systems.
There was a problem hiding this comment.
Hmm, You are right, this only passes the wrench tests. In servo we still fail the gradient test.
I'm missing something...
dati91
changed the title
For the latter, I think we can get away with a simpler approach than having 2 textures. E.g. the shaders may have a feature to just invert the Y before sampling the dither texture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #158
GL result
VK result
(It was
number of differing pixels: 47483before this)