Add support for building UKI addons #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NekkoDroid
force-pushed
the
mkosi-uki-addons
branch
from
760bfd1
to
b7796d9
Compare
behrmann
reviewed
Sep 28, 2024
NekkoDroid
force-pushed
the
mkosi-uki-addons
branch
from
b7796d9
to
deb492e
Compare
DaanDeMeyer
requested changes
Sep 28, 2024
NekkoDroid
force-pushed
the
mkosi-uki-addons
branch
5 times, most recently
from
862e239
to
105d81c
Compare
DaanDeMeyer
requested changes
Sep 28, 2024
DaanDeMeyer
reviewed
Sep 28, 2024
DaanDeMeyer
reviewed
Sep 28, 2024
DaanDeMeyer
reviewed
Sep 28, 2024
NekkoDroid
force-pushed
the
mkosi-uki-addons
branch
from
105d81c
to
def34ea
Compare
NekkoDroid
force-pushed
the
mkosi-uki-addons
branch
from
def34ea
to
807f429
Compare
DaanDeMeyer
approved these changes
Sep 29, 2024
behrmann
reviewed
Sep 29, 2024
| @@ -4479,6 +4489,7 @@ def summary(config: Config) -> str: | |||
| Shim Bootloader: {config.shim_bootloader} | |||
| Unified Kernel Images: {config.unified_kernel_images} | |||
| Unified Kernel Image Format: {config.unified_kernel_image_format} | |||
| Unified Kernel Image Addons: {line_join_list(config.pe_addons)} | |||
There was a problem hiding this comment.
A bit too late at this, but I think this should mention "PE" somehow, too, e.g. "Unified Kernel Image PE Addons", since the option is named --pe-addon, that is what I would grep for in the output of mkosi summary.
There was a problem hiding this comment.
Woops, forgot to rename that. Probably should only be "PE Addons" since that is what they are referred to in the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not something I personally need anymore (so feel free to close), but I already implemented it and thought this might be useful to some.
This basically just reuses
ukifys ability to take config files in which you can configure whatever (e.g.Cmdline=,DeviceTree=, ...) and passes the output target and secure boot parameters when needed. This should allow additions toukifywithout needing to update the code here.