Prefer config.image over config.image_id
#2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `mkosi.images` it makes more sense to use the `image` name, as that is what identifies the different images.
DaanDeMeyer
approved these changes
May 15, 2024
behrmann
approved these changes
May 15, 2024
|
This broke my current setup with multiple profiles, I set different My setupmkosi.images/
├── base
│ ├── mkosi.conf
│ └── mkosi.configure
├── initrd
│ ├── mkosi.conf
│ ├── mkosi.conf.d
│ │ ├── 10-aaa
│ │ │ ├── mkosi.conf
│ │ │ └── mkosi.extra
│ │ └── 20-bbb
│ │ ├── mkosi.conf
│ │ └── mkosi.extra
│ └── mkosi.extra
└── systemThis previously produced 3 initrd images, default |
|
No because you might want an initrd, main image and exitrd all with the same image id. @ragazenta Can you switch to Output= by any chance? |
Ah, I see. Thanks. |
|
The docs for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it currently stands, when using multiple images via
mkosi.imagesall the images have the same (output) name ifImageId=is set, which results in all images needing to override the output name as to not clash.This changes the default output name and the display name of those images to prefer their actual "sub-image" name, while still falling back to the
ImageId=for the root image case.This also somewhat has the sideeffect that it solves the original issue I had in #2566 (but the requested specifier might still be useful, so I'll keep it open for now).