Adding an optional check to remove disposable emails #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtayyeb
suggested changes
Mar 25, 2017
validate_email.py
Outdated
| @@ -96,6 +97,17 @@ class ServerError(Exception): | |||
| MX_CHECK_CACHE = {} | |||
|
|
|||
|
|
|||
| def is_disposable(email, debug=False): | |||
| """Indicate whether the email is known as being a disposable email or not""" | |||
| for domain in _disposable: | |||
There was a problem hiding this comment.
no no! do it better
do it like this:
email_domain = email.rsplit('@',1)[1]
if email_domain in _disposable:
# logger stuff
return True
return False
…osable domains to a set for faster lookup
|
@wtayyeb thanks for your advices, I also took the liberty to change the list of disposable domains to a set, since the lookup is faster in a set than in a list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an optional check to prevent validating disposable emails