fix #58 - Call to a member function getCallable() on bool. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oallain
commented
Sep 17, 2023
oallain
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Fixed issue | #58 |
oallain
changed the title
src/Twig/GdprExtension.php
Outdated
| @@ -21,7 +21,7 @@ public function hasPermission(Environment $env, string $permission): bool | |||
| { | |||
| $function = $env->getFunction('sylius_plus_rbac_has_permission'); | |||
|
|
|||
| if ($function !== null && is_callable($function->getCallable())) { | |||
| if (is_object($function) && is_callable($function->getCallable())) { | |||
There was a problem hiding this comment.
In my opinion it's pretty weird to check if a variable called "function" is an object or not
There was a problem hiding this comment.
The method signature has changed between Twig v2 and Twig v3.
Twig v2
/**
* @return TwigFunction|false
*/
public function getFunction($name)In Twig v3
public function getFunction(string $name): ?TwigFunctionSo check only with null is not enough.
Jibbarth
reviewed
Sep 20, 2023
oallain
force-pushed
the
fix/issue-58
branch
from
7eccb49
to
a4c8dec
Compare
Jibbarth
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.