chore: Add transfers by domain route #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrun5
requested changes
Sep 10, 2024
| querystring: { | ||
| type: "object", | ||
| properties: { | ||
| ...paginationSchema, | ||
| domain: { | ||
| type: "string", | ||
| default: "source", | ||
| default: undefined, |
There was a problem hiding this comment.
This might break something on explorer-ui if it assumed source right now.
@tcar121293 Do you know how this is used right now?
There was a problem hiding this comment.
@wainola can you validate this also
There was a problem hiding this comment.
this means it can be undefined, doesn't it? if so, yes, it would break explorer as is a property we are using to render info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified an existing route so that it is possible to get all transfers where a specific domain is either a source domain or a destination domain.