feat: Multiple GSRPC version support #31
Conversation
| GenesisHash types.Hash // Chain genesis hash | ||
| } | ||
|
|
||
| func NewCheckMetadataModeEnabledConnection(url string) (*CheckMetadataModeEnabledConnection, error) { |
There was a problem hiding this comment.
Can we instead creating another connection just pass in the client instead so we don't copy paste connections?
| "github.com/sygmaprotocol/sygma-core/chains/substrate/events" | ||
| ) | ||
|
|
||
| type SubstrateCheckMetadataModeEnabledClient struct { |
There was a problem hiding this comment.
What's different here exactly?
Anyway to write so it is not directly copy-pasted?
There was a problem hiding this comment.
@mpetrun5 I was looking for a way to only change the type of SignatureOptions but the new version of it added two more parameters, so if only changing the type, it will not be able to convert to the old version and pass to the submitAndWatchExtrinsic. That's why instead of changing only SignatureOptions, I copied the entire Client implementation with new version so there is no type matching issue, same reason for the connection implementation. Obversely it creates duplications which is bad, good side is that it doesn't touch the current implementation at all and if GSRPC is released with compatibility issue fixing, we can simply remove this duplication.
To my understanding, this multiple GSRPC support is only a temporary solution until Centrifuge fix on their side. Please correct me if I'm wrong.
There was a problem hiding this comment.
I can live this I guess, but let's not merge into main then.
Create a separate feature branch and we will install on relayer temporarily as such and then create a separate fix later.
I would honestly prefer it being inside one client as by their comments I don't foresee them fixing this quickly, but a temporary branch might be ok.
freddyli7
changed the title
|
Go Test coverage is 48.4 %\ ✨ ✨ ✨ |
freddyli7
changed the title
freddyli7
requested review from
tcar121293,
MakMuftic and
nmlinaric
as code owners
Description
Related Issue Or Context
Closes: #
How Has This Been Tested? Testing details.
Types of changes
Checklist: