Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Converting message and proposal fields to generics #19

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

mj52951
Copy link

@mj52951 mj52951 commented Dec 11, 2023

Changed data field inside message and proposal from interface{} to a generic type.

Closes: #18

Copy link

Go Test coverage is 69.0 %\ ✨ ✨ ✨

@mj52951 mj52951 changed the title Converting message and proposal fields to generics chore: Converting message and proposal fields to generics Dec 12, 2023
@mpetrun5
Copy link

mpetrun5 commented Jan 3, 2024

@MakMuftic Can you please also check this?

Copy link

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary generics

Copy link

github-actions bot commented Jan 4, 2024

Go Test coverage is 69.0 %\ ✨ ✨ ✨

@mj52951 mj52951 requested a review from mpetrun5 January 4, 2024 09:33
@mj52951 mj52951 merged commit afa6819 into main Jan 4, 2024
7 checks passed
@mpetrun5 mpetrun5 deleted the mj52951/refactor-generics branch January 4, 2024 10:06
mj52951 pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor message and proposal so they support generics
3 participants