Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check hashi message #48

Merged
merged 10 commits into from
Sep 16, 2024
Merged

feat: check hashi message #48

merged 10 commits into from
Sep 16, 2024

Conversation

mpetrun5
Copy link
Contributor

@mpetrun5 mpetrun5 commented Sep 16, 2024 •
edited
Loading

Description

Fetch hashi message and if it exists submit the spectre proof on target domains.
Refactor step handler so it can support multiple source handlers that collects domains.

Related Issue Or Context

Closes: #47

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@mpetrun5 mpetrun5 changed the title Mpetrun5/check hashi message feat: check hashi message Sep 16, 2024
@github-actions GitHub Actions
Copy link

Go Test coverage is 94.0 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link

Go Test coverage is 94.0 %\ ✨ ✨ ✨

MakMuftic
MakMuftic approved these changes Sep 16, 2024
View reviewed changes
Copy link

@MakMuftic MakMuftic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mpetrun5 mpetrun5 merged commit 8babdef into main Sep 16, 2024
8 checks passed
@mpetrun5 mpetrun5 deleted the mpetrun5/check-hashi-message branch September 16, 2024 15:52
@mpetrun5 mpetrun5 mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@nmlinaric nmlinaric nmlinaric approved these changes

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle hashi messages
3 participants
@mpetrun5 @MakMuftic @nmlinaric