Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send step only for filled epochs #33

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

mpetrun5
Copy link
Contributor

@mpetrun5 mpetrun5 commented Feb 7, 2024

Sends step only for filled epoch when a deposit is found from the last processed block number.
Note On restarts submit to all domains to prevent missing any steps

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

**Note** On restarts submit to all domains to prevent missing any steps
Copy link

github-actions bot commented Feb 7, 2024

Go Test coverage is 56.9 %\ ✨ ✨ ✨

Copy link

github-actions bot commented Feb 7, 2024

Go Test coverage is 92.2 %\ ✨ ✨ ✨

Copy link

github-actions bot commented Feb 7, 2024

Go Test coverage is 92.2 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit bc2f287 into main Feb 9, 2024
8 checks passed
@mpetrun5 mpetrun5 deleted the mpetrun5/send-step-on-deposit branch February 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants