separated the catergories without subs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allynkalda
reviewed
Sep 22, 2022
| gap: 2rem; | ||
| grid-template-columns: repeat(auto-fill, minmax(200px, 1fr)); | ||
| display: flex; | ||
| /* display: grid; */ |
There was a problem hiding this comment.
Are these stylings that are commented out necessary here or can we remove?
GesJeremie
reviewed
Sep 22, 2022
| @@ -222,6 +225,66 @@ const Submenu: FC<ItemProps> = observer((props) => { | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| [departmentActive, collapsibleStates] | |||
| ) | |||
|
|
|||
| const itemsWithNoSubCategories = useMemo( | |||
There was a problem hiding this comment.
Looking at the file, it seems that there's a fair bit of duplication between itemsWithSubCategories / items – We might want to extract the following, somehow:
mega-menu/react/MegaMenu/components/Submenu.tsx
Lines 119 to 136 in dc7e3cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
The design was a little off, It's not perfect but it's much closer
How should this be manually tested?
Test here WITI - 272
Screenshots or example usage:
